[ https://issues.apache.org/jira/browse/HBASE-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724600#comment-13724600 ]
Hadoop QA commented on HBASE-9094: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595067/dep.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:red}-1 hadoop1.0{color}. The patch failed to compile against the hadoop 1.0 profile. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6531//console This message is automatically generated. > Rationalize dependencies; fix analysis complaints about used but non-declared > dependencies > ------------------------------------------------------------------------------------------ > > Key: HBASE-9094 > URL: https://issues.apache.org/jira/browse/HBASE-9094 > Project: HBase > Issue Type: Sub-task > Components: build > Reporter: stack > Assignee: stack > Fix For: 0.98.0, 0.95.2 > > Attachments: dep.txt > > > Do a cleanup pass through our dependency set so downstreamers get good > picture of what they need to include looking at pom. > Poking with dependency plugin, found the following issues: > + hbase-common is missing listing of a bunch of commons libs > + Some of our classes make use of slf4j for no good reason. zk, thrift, > netty, and yammer, use slf4j but no need for us to be in the slf4j managing > game... so I undid our use of it and stop its transitive include everywhere. > + hbase-examples and hbase-it do not declare includes like hbase-client, > hbase-protocol, etc. > + hbase-hadoop1-compat depended on log4j but doesn't use it. > + hbase-prefix-tree depends on hadoop but does not declare it (uses > WritiableUtil and RawComparator -- just two imports... uses the Audience > annotations which we could just remove but still these two critical includes) > + hbase-server wasn't declaring its use of commons-*. Also added excludes of > transitive include of log4j by zk and yammer. Got rid of slf4j as a > dependency. > + Add declarations for used libs such as httpclient and commons-math to > top-level pom. > + Removed setting versions on hadoop1 and hadoop2 profile for slf4j mess. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira