[ 
https://issues.apache.org/jira/browse/HBASE-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728192#comment-13728192
 ] 

Jean-Daniel Cryans commented on HBASE-7183:
-------------------------------------------

[~webster], thank you for the patch. I see you have one long line in there, 
they should not be longer than 100 characters (HadoopQA will probably -1 it for 
that), but apart from that I'm +1. Please have a look at the dev guidelines for 
your future contributions: http://hbase.apache.org/book.html#developing

If this is the only problem that HadoopQA finds, I'll fix it when committing 
instead of having you post a new patch.
                
> print WARN message if hbase.replication.sizeOfLogQueue is too big
> -----------------------------------------------------------------
>
>                 Key: HBASE-7183
>                 URL: https://issues.apache.org/jira/browse/HBASE-7183
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Sho Shimauchi
>              Labels: noob
>         Attachments: HBASE_7183.patch, HBASE_7183-v2.patch
>
>
> A metric hbase.replication.sizeOfLogQueue may become big when replication is 
> delaying.
> It would be useful if HBase prints WARN log which tells 
> hbase.replication.sizeOfLogQueue is too big.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to