[ https://issues.apache.org/jira/browse/HBASE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733894#comment-13733894 ]
Himanshu Vashishtha commented on HBASE-8670: -------------------------------------------- Any specific reason why the first pause is 3sec, and not 4sec as in trunk (little bit higher than default dfs heartbeat)? https://github.com/apache/hbase/blob/0.94/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java#L93 https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java#L93 > [0.94] Backport HBASE-8449,HBASE-8204 and HBASE-8699 to 0.94 (Refactor > recoverLease retries and pauses) > ------------------------------------------------------------------------------------------------------- > > Key: HBASE-8670 > URL: https://issues.apache.org/jira/browse/HBASE-8670 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration, master, wal > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 0.94.11 > > Attachments: hbase-8670_v1.patch, hbase-8670_v2.patch > > > Some history: > Up until 0.94.8, Hbase did not check the result of recoverLease() call, but > things kind of worked since we are checking for 0-length files in distributed > log split tasks from region servers. If lease recovery is not finished, the > log file will report 0 length, and the task will fail, and master will then > re-call recoverLease() and reassign the task. This scheme might fail for log > files that are larger than 1 hdfs block though. > In 0.94.8, we committed (HBASE-8354, which is backport of HBASE-7878) and > later increased the sleep time to 4 secs in HBASE-8389. > However, the proper solution arrived in trunk in HBASE-8449 which uses a > backoff sleep policy + isFileClosed() api. We should backport this patch to > 0.94 as well. > isFileClosed() is released in Hadoop 1.2.0 (HDFS-4774) and 2.0.5(HDFS-4525). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira