[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738741#comment-13738741 ]
Nicolas Liochon commented on HBASE-7462: ---------------------------------------- I haven't run it, but it seems ok. Here are some comments: import with starts => should be replaced by all imports (simplifie backports) public void testAssignmentManagerDoesntUseDrainedServerWithBulkAssign() throws ServiceException, InterruptedException, IOException, KeeperException, NoSuchFieldException, IllegalAccessException { => Can be simplified by throwing Exception only /** * Put region opened on ZooKeeper * * @param zkWatcher * @param serverName * @param hregionInfo * @throws KeeperException * @throws InterruptedException */ => you can remove the @params here, as there is no documentation As well, line length should be less than 100 chars. I'm not sure it's always the case. > TestDrainingServer is an integration test. It should be a unit test instead > --------------------------------------------------------------------------- > > Key: HBASE-7462 > URL: https://issues.apache.org/jira/browse/HBASE-7462 > Project: HBase > Issue Type: Wish > Components: test > Affects Versions: 0.95.2 > Reporter: Nicolas Liochon > Assignee: Gustavo Anatoly > Priority: Trivial > Labels: noob > Attachments: HBASE-7462-v1.patch > > > TestDrainingServer tests the function that allows to say that a regionserver > should not get new regions. > As it is written today, it's an integration test: it starts & stops a cluster. > The test would be more efficient if it would just check that the > AssignmentManager does not use the drained region server; whatever the > circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira