[ https://issues.apache.org/jira/browse/HBASE-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741077#comment-13741077 ]
stack commented on HBASE-9164: ------------------------------ This cleans up the code. Nice. Thanks for doing this [~jmhsieh] What about this: {code} - @Deprecated - public long getMemstoreTS() { - return getMvccVersion(); - } - - @Deprecated - public void setMemstoreTS(long memstoreTS) { - setMvccVersion(memstoreTS); - } {code} Is this leakage from another recent refactoring of yours? Doing Cell-based compare in KV and narrowing the specialization -- i.e. in meta comparator only specialize the row compare -- is great +1 Thanks for cleaning up the mess I made. > Convert List<? extends Cell> anti pattern to List<Cell> pattern. > ---------------------------------------------------------------- > > Key: HBASE-9164 > URL: https://issues.apache.org/jira/browse/HBASE-9164 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.95.1 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Priority: Blocker > Fix For: 0.95.2 > > Attachments: hbase-9164.patch, hbase-9164.v2.patch > > > As described in HBASE-9142, using List<? extends Cell> is an anti pattern > that adds unnecessary typing and casting clutter to the code base. It would > be best to remove this before we release 0.95.2 or 0.96. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira