[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744350#comment-13744350 ]
Nick Dimiduk commented on HBASE-9116: ------------------------------------- This looks like it needs rebased onto trunk. The posted patch includes generated code ({{AdminProtos.java}}), please remove. Please add javadoc for the new classes and new public methods on existing classes. {{FavoredNodeAssignmentHelper#placeSecondaryAndTertiaryWithRestrictions}} introduces a {{while(true)}} block containing non-trivial branching logic. Can this be refactored with simpler and/or clearer break conditions? {{FSUtils}} introduces new configuration {{hbase.client.localityCheck.threadPoolSize}}. Can this be added to {{HConstants}} and/or documented in {{hbase-defaults.xml}}? > Add a view/edit tool for favored node mappings for regions > ---------------------------------------------------------- > > Key: HBASE-9116 > URL: https://issues.apache.org/jira/browse/HBASE-9116 > Project: HBase > Issue Type: Improvement > Components: Region Assignment > Affects Versions: 0.95.0 > Reporter: Devaraj Das > Assignee: Devaraj Das > Attachments: 9116-1.txt > > > Add a tool that one can run offline to view the favored node mappings for > regions, and also fix the mappings if needed. Such a tool exists in the > 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira