[
https://issues.apache.org/jira/browse/HBASE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747723#comment-13747723
]
Eric Charles commented on HBASE-9299:
-------------------------------------
I began using that plugin to allow me testing a various builds 2.4.1 (just like
trunk was sometime ago) with 2.5.
Using a Hbase (proto-2.4.1) againt a recent Hadoop (proto-2.5) was breaking the
communication.
Now that HBase trunk uses proto-2.5, it is easier and the added-value of the
maven plugin makes less sense.
Btw, I tested hbase trunk (proto 2.5) agains hadoop 1.2.1, 2.0.5, and 3.0, it
all works fine.
For the doc, I would have indeed put that in a README, but just under
hbase-protocol.
The current README.txt is a bit too general. I should contain the exacts
command to copy/paste and run with the I and java_out params.
http://hbase.apache.org/book/developer.html should also contain a section that
explains how protobuf is used and what to do in case of change, and link to the
README in the src.
Once we agree on what to do, I am happy to submit a patch that implements our
decisions.
> Generate the protobuf classes with hadoop-maven-plugin
> ------------------------------------------------------
>
> Key: HBASE-9299
> URL: https://issues.apache.org/jira/browse/HBASE-9299
> Project: HBase
> Issue Type: New Feature
> Reporter: Eric Charles
>
> For now, the protobuf classes are generated once by a dev, and put in
> src/main/resouce.
> This allows the other dev to not have the correct protoc version available on
> their machine. However, when a dev wants to modify the protoc messages, he
> has to know how to generate the classes. This could be documented...
> Another approach would be to put a harder requirement on the hbase developers
> (protoc available) and let the hadoop-maven-plugin
> (http://central.maven.org/maven2/org/apache/hadoop/hadoop-maven-plugins/2.0.5-alpha)
> to do the work (I have bad experience with other maven protobuf plugins, the
> hadoop one works just out of the box).
> I don't think asking to install protoc to build hbase is so difficult, but
> that's an additional step between the dev and the artifcat.
> The advantage would be to allow to have different protobuf versions for
> different hbase distributions (perfectly possible but quite theorical).
> So
> option 1: We are happy to keep the classes in src/main/java
> option 2: We want to move to hadoop-maven-plugin
> option 3: I may be short of idea... any other input?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
