[ https://issues.apache.org/jira/browse/HBASE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749681#comment-13749681 ]
Hadoop QA commented on HBASE-9307: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12599490/HBASE-9307.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:red}-1 release audit{color}. The applied patch generated 2 release audit warnings (more than the trunk's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6882//console This message is automatically generated. > HalfStoreFileReader needs to handle the faked key else compactions go into > infinite loops > ----------------------------------------------------------------------------------------- > > Key: HBASE-9307 > URL: https://issues.apache.org/jira/browse/HBASE-9307 > Project: HBase > Issue Type: Bug > Affects Versions: 0.95.2 > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Priority: Critical > Fix For: 0.98.0, 0.96.0 > > Attachments: HBASE-9307.patch > > > I found this while trying out 0.95.2 > I couldn't shut my cluster down because one region was still compacting, but > it already had been doing that for an hour and it only had 80MBs of data. > Debugging I saw that it was a post-split compaction, specifically for the top > part of the HFiles, and that it was just spinning on the first entry in the > file. > Eventually I saw that the anonymous HFileScanner inside > HalfStoreFileReader.getScanner (that's so dirty) wasn't handling > HConstants.INDEX_KEY_MAGIC in seekTo() when calling this: > bq. this.delegate.seekTo(splitkey) > Instead it would treat this as if the split key wasn't in the file, but still > seek back to the beginning of the file *then read on from there*. > During the compaction it would see a KV that's not even part of the region, > and it just tries to find the correct block over and over again. > This came from HBASE-7845. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira