[ https://issues.apache.org/jira/browse/HBASE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752919#comment-13752919 ]
Hudson commented on HBASE-9299: ------------------------------- SUCCESS: Integrated in HBase-TRUNK #4441 (See [https://builds.apache.org/job/HBase-TRUNK/4441/]) HBASE-9299 Generate the protobuf classes with hadoop-maven-plugin (stack: rev 1518312) * /hbase/trunk/hbase-protocol/README.txt * /hbase/trunk/hbase-protocol/pom.xml * /hbase/trunk/hbase-protocol/src/main/protobuf/README.txt * /hbase/trunk/src/main/docbkx/developer.xml > Generate the protobuf classes with hadoop-maven-plugin > ------------------------------------------------------ > > Key: HBASE-9299 > URL: https://issues.apache.org/jira/browse/HBASE-9299 > Project: HBase > Issue Type: New Feature > Reporter: Eric Charles > Assignee: Eric Charles > Fix For: 0.98.0, 0.96.0 > > Attachments: HBASE-9299.patch > > > For now, the protobuf classes are generated once by a dev, and put in > src/main/resouce. > This allows the other dev to not have the correct protoc version available on > their machine. However, when a dev wants to modify the protoc messages, he > has to know how to generate the classes. This could be documented... > Another approach would be to put a harder requirement on the hbase developers > (protoc available) and let the hadoop-maven-plugin > (http://central.maven.org/maven2/org/apache/hadoop/hadoop-maven-plugins/2.0.5-alpha) > to do the work (I have bad experience with other maven protobuf plugins, the > hadoop one works just out of the box). > I don't think asking to install protoc to build hbase is so difficult, but > that's an additional step between the dev and the artifcat. > The advantage would be to allow to have different protobuf versions for > different hbase distributions (perfectly possible but quite theorical). > So > option 1: We are happy to keep the classes in src/main/java > option 2: We want to move to hadoop-maven-plugin > option 3: I may be short of idea... any other input? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira