[
https://issues.apache.org/jira/browse/HBASE-9481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763095#comment-13763095
]
Jimmy Xiang edited comment on HBASE-9481 at 9/10/13 3:02 PM:
-------------------------------------------------------------
[~stack], the patch looks good to me because all the access to
regionsInTransition (and other region states member variables) are
synchronized. The gap is widened, but accessing to in-memory state is also
delayed due to the synchronization. Another way is to use Iterator, which
needs a little bit refactory. Either way is fine with me.
was (Author: jxiang):
[~saint....@gmail.com], the patch looks good to me because all the access
to regionsInTransition (and other region states member variables) are
synchronized. The gap is widened, but accessing to in-memory state is also
delayed due to the synchronization. Another way is to use Iterator, which
needs a little bit refactory. Either way is fine with me.
> Servershutdown handler get aborted with ConcurrentModificationException
> -----------------------------------------------------------------------
>
> Key: HBASE-9481
> URL: https://issues.apache.org/jira/browse/HBASE-9481
> Project: HBase
> Issue Type: Bug
> Components: MTTR
> Affects Versions: 0.96.0
> Reporter: Jeffrey Zhong
> Assignee: Jeffrey Zhong
> Attachments: hbase-9481.patch
>
>
> In integration tests, we found SSH got aborted with following stack trace:
> {code}
> 13/09/07 18:10:00 ERROR executor.EventHandler: Caught throwable while
> processing event M_SERVER_SHUTDOWN
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793)
> at java.util.HashMap$ValueIterator.next(HashMap.java:822)
> at
> org.apache.hadoop.hbase.master.RegionStates.serverOffline(RegionStates.java:378)
> at
> org.apache.hadoop.hbase.master.AssignmentManager.processServerShutdown(AssignmentManager.java:3143)
> at
> org.apache.hadoop.hbase.master.handler.ServerShutdownHandler.process(ServerShutdownHandler.java:207)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:131)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
