[ 
https://issues.apache.org/jira/browse/HBASE-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763169#comment-13763169
 ] 

Dave Latham commented on HBASE-9377:
------------------------------------

Didn't notice the InterfaceAudience.private.  With that, I agree with #2.

For your modified patch, it means that not all included log cleaners extend the 
BaseLogCleanerDelegate.  If you like that better than supplying a default 
implementation for BaseLogCleanerDelegate.isLogDeletable, it doesn't make much 
difference to me.
+0

It does look like the patch is missing BaseFileCleanerDelegate.java though.

Thanks, Lars, for pushing on it.
                
> Backport HBASE- 9208 "ReplicationLogCleaner slow at large scale"
> ----------------------------------------------------------------
>
>                 Key: HBASE-9377
>                 URL: https://issues.apache.org/jira/browse/HBASE-9377
>             Project: HBase
>          Issue Type: Task
>          Components: Replication
>            Reporter: stack
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.12
>
>         Attachments: 9377.txt
>
>
> For [~lhofhansl] to make a  call on.  See end where Dave Latham talks about 
> issues w/ patch in 0.94.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to