[ https://issues.apache.org/jira/browse/HBASE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043039#comment-13043039 ]
jirapos...@reviews.apache.org commented on HBASE-451: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/849/ ----------------------------------------------------------- Review request for hbase. Summary ------- Posting for Subbu See issue for his description of change. This addresses bug HBASE-451. https://issues.apache.org/jira/browse/HBASE-451 Diffs ----- src/main/java/org/apache/hadoop/hbase/HConstants.java bd4c64c src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 9502b1d src/main/java/org/apache/hadoop/hbase/HRegionInfoForMigration.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/KeyValue.java 7033800 src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java a25b0f0 src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java eb57197 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 7594822 src/main/java/org/apache/hadoop/hbase/client/HConnection.java f722155 src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 94ee1a0 src/main/java/org/apache/hadoop/hbase/client/HTable.java c82e1dd src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 2734f30 src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHRegionInfo.java 23e7a6b src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java d531b8d src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 4704c39 src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 38914a8 src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java 5b4a4b7 src/main/java/org/apache/hadoop/hbase/master/HMaster.java b8489ac src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java b22a3e4 src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java c98ed17 src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 5a8bb20 src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 6380520 src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 3d16e47 src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java dace150 src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java fcea483 src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java a963c6c src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java 4029893 src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java e5bd154 src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java 9ccf248 src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 072fd8d src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 21468ad src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java ba2daa9 src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 0716788 src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALObserver.java 3def4b6 src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java 1a87947 src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 3409108 src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 39591a0 src/main/java/org/apache/hadoop/hbase/util/HMerge.java c07f8dc src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java 540d7df src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java 6d0c803 src/main/java/org/apache/hadoop/hbase/util/Writables.java 3e60f97 src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java 4c58791 src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java babd788 src/test/java/org/apache/hadoop/hbase/TestCompare.java bbac815 src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java 1f51703 src/test/java/org/apache/hadoop/hbase/TestSerialization.java 05f0efc src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 1105509 src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java c3b23fe src/test/java/org/apache/hadoop/hbase/client/TestMetaMigration.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java db42192 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java f0418d1 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 46ba184 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 18380c6 src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 19397fb src/test/java/org/apache/hadoop/hbase/filter/TestColumnPrefixFilter.java e1eb02a src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java 04705c3 src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java bfa3c72 src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java ada2af6 src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java ba87bc0 src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java d909997 src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 2022767 src/test/java/org/apache/hadoop/hbase/master/TestMasterStatusServlet.java 1fef788 src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java e2f4507 src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java 48fa162 src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 3b7c7e8 src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java e106b45 src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 516139b src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 40d352e src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java f092371 src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java ef8a4b2 src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java b85b912 src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java dbe5fb1 src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java 2cc197f src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java bcf9024 src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java e2c158a src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALObserver.java 5b95154 src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java 4de5b95 src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java 3f9302a src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java c02dfda src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a6bdbe0 src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java 3039df2 src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java 18cd055 Diff: https://reviews.apache.org/r/849/diff Testing ------- Thanks, Michael > Remove HTableDescriptor from HRegionInfo > ---------------------------------------- > > Key: HBASE-451 > URL: https://issues.apache.org/jira/browse/HBASE-451 > Project: HBase > Issue Type: Improvement > Components: master, regionserver > Affects Versions: 0.2.0 > Reporter: Jim Kellerman > Assignee: Subbu M Iyer > Priority: Critical > Fix For: 0.92.0 > > Attachments: 451_support_for_removing_HTD_from_HRI_trunk.txt, > HBASE-451_-_First_draft_support_for_removing_HTD_from_HRI1.patch > > > There is an HRegionInfo for every region in HBase. Currently HRegionInfo also > contains the HTableDescriptor (the schema). That means we store the schema n > times where n is the number of regions in the table. > Additionally, for every region of the same table that the region server has > open, there is a copy of the schema. Thus it is stored in memory once for > each open region. > If HRegionInfo merely contained the table name the HTableDescriptor could be > stored in a separate file and easily found. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira