[ https://issues.apache.org/jira/browse/HBASE-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045180#comment-13045180 ]
jirapos...@reviews.apache.org commented on HBASE-2233: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/858/ ----------------------------------------------------------- Review request for hbase. Summary ------- Patch for HBASE TRUNK that makes it so we run on hadoop 0.20.x or hadoop 0.22 branch (as it is now). Needed hdfs-1948 and hadoop-7531 applied to hadoop 0.22 branch. Because these issues are NOT in hadoop 0.21, hbase will not work against 0.21 hadoop, not w/o these patches and a rebuild. This addresses bug HBASE-2233. https://issues.apache.org/jira/browse/HBASE-2233 Diffs ----- src/main/java/org/apache/hadoop/hbase/ipc/ConnectionHeader.java c2a7649 src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java 95407d1 src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport/InputSampler.java c3e0a68 src/main/java/org/apache/hadoop/hbase/master/HMaster.java b8489ac src/main/java/org/apache/hadoop/hbase/master/ServerManager.java f735e41 src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6404538 src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 0716788 src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java db29e56 src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java 8dc9a5e src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 3409108 src/main/java/org/apache/hadoop/hbase/util/InfoServer.java 6ed9fe6 src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java babd788 src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java f6a7210 src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java f1f4c6b src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 5b487a9 src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java c8fc065 Diff: https://reviews.apache.org/r/858/diff Testing ------- Ran this patch with hadoop 0.20 and hadoop 0.22 underneath hbase (I used the patch for the pom that is attached to the issue to switch to hadoop 0.22). All unit tests seem to pass except TestHFileOutputFormat when up on hadoop 0.22; hadoop 0.22 uses avro 1.3.2 whereas hbase is up on avro 1.4.1. The test fails with a method not found exception. You need to enable mapreduce logging to see the exception. Thanks, Michael > Support both Hadoop 0.20, 0.21, and 0.22 > ---------------------------------------- > > Key: HBASE-2233 > URL: https://issues.apache.org/jira/browse/HBASE-2233 > Project: HBase > Issue Type: New Feature > Reporter: Jean-Daniel Cryans > Priority: Critical > Fix For: 0.92.0 > > Attachments: 2233-v2.txt, 2233-v3.txt, 2233-v4.txt, 2233-v5.txt, > 2233.txt, pom.to.go.against.hadoop.trunk.txt > > > Since Hadoop 0.21 isn't going to be well supported and that a lot of users > may wish to stick on 0.20, the next HBase major release should support both > 0.20 and 0.21. > HDFS-265 support will be swapped for HDFS-200 if running on HDFS 0.20. A > cluster without that patchset shouldn't be supported. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira