[
https://issues.apache.org/jira/browse/HBASE-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788115#comment-13788115
]
Anoop Sam John commented on HBASE-9137:
---------------------------------------
bq.As far as I can tell, TagCompressionContext is only used in WAL related
classes. How is HFile related ?
Removed HFile from the comment as of now. Will add when submitting patch for
tag compression in HFiles
bq.Is wildcard necessary above ?
Yes
bq.Add assertion that pos < endOffset before the while loop ?
Yes we can. Done
bq.There're 3 variants for uncompressTags(). Can you add javadoc for them
explaining use case ?
Removed keeping just one. Other were used by tag compression in HFiles. Will
add with that patch. Added javadoc for current compress, uncompress methods.
bq.More comments to follow once patch posted on rb.
Thanks for initial look Ted. Expecting review on other parts too. :)
> Add Tag dictionary in WAL compression
> -------------------------------------
>
> Key: HBASE-9137
> URL: https://issues.apache.org/jira/browse/HBASE-9137
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.98.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.98.0
>
> Attachments: HBASE-9137.patch, HBASE-9137_V2.patch
>
>
> We can add tag dictionary like we have one for rowdictionary,
> familydictionary. But this has to be done after stabilizing HBASE-7391.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
