[
https://issues.apache.org/jira/browse/HBASE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797559#comment-13797559
]
Ted Yu commented on HBASE-9769:
-------------------------------
Please add annotation for audience and stability:
{code}
+public class ExplicitScanReplacementFilter extends FilterBase {
{code}
Should it be in org.apache.hadoop.hbase.filter package ?
{code}
+package org.apache.hadoop.hbase.regionserver;
{code}
{code}
+ private boolean doesUseExplicitColumnFilter(Scan scan) {
{code}
Name the method shouldUseExplicitColumnFilter() ?
{code}
+ if (cols != null && (cols.size() > 1 || cols.first() != null)) {
{code}
Why is cols.size() > 1 check needed ?
Can you add a test for the new class ?
> Improve performance of a Scanner with explicit column list when rows are
> small/medium size
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-9769
> URL: https://issues.apache.org/jira/browse/HBASE-9769
> Project: HBase
> Issue Type: Improvement
> Components: Scanners
> Affects Versions: 0.98.0, 0.94.12, 0.96.0
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Attachments: 9769-0.94-sample1.txt, 9769-0.94-sample2.txt,
> 9769-0.94-sample.txt, 9769-94.txt, 9769-94-v2.txt, 9769-trunk-v1.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
