[ https://issues.apache.org/jira/browse/HBASE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798309#comment-13798309 ]
stack commented on HBASE-8496: ------------------------------ Shouldn't this issue have a release note? I marked it as reviewed and an incompatible change (is that right?). What should we add to the refguide on tags? Or, we are not ready to add anything there just yet? On the updated design doc: There is nothing in the way of altering how tags are currently added, right? It is just done this way for expediency given so much of the core is still up on KV. The below should be 0 or more... right? Every KV can have 1 or more tags. .... hmm... nevermind the rest of the comments. It looks like this design doc. is a long way from what was implemented. np. We just need a bit of a write up on what went in.... before 0.98. Can ignore the below. On slide #3, every tag has a type byte preceeding it? On slide #3 you don't say what a tag is? Just a run of bytes? Oh, so looks like the implementation has deviated from the design, right? OK. Is it written up in short form anywhere? What was implemented? The tag structure on slide #5 is different from what is on #3. On #5 it talks of a tagarray (am I being too literal)? Are there big changes between hfilev2 and hfilev3? They seem small going by this design doc. > Implement tags and the internals of how a tag should look like > -------------------------------------------------------------- > > Key: HBASE-8496 > URL: https://issues.apache.org/jira/browse/HBASE-8496 > Project: HBase > Issue Type: New Feature > Affects Versions: 0.98.0, 0.95.2 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Critical > Fix For: 0.98.0 > > Attachments: Comparison.pdf, HBASE-8496_2.patch, HBASE-8496_3.patch, > HBASE-8496_3.patch, HBASE-8496_3.patch, HBASE-8496_4.patch, > HBASE-8496_5.patch, HBASE-8496_6.patch, HBASE-8496.patch, > Performance_report.xlsx, Tag design.pdf, Tag design_updated.pdf, > Tag_In_KV_Buffer_For_reference.patch > > > The intent of this JIRA comes from HBASE-7897. > This would help us to decide on the structure and format of how the tags > should look like. -- This message was sent by Atlassian JIRA (v6.1#6144)