[ https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808380#comment-13808380 ]
Andrew Purtell commented on HBASE-9816: --------------------------------------- For HBase internals, 256 type codes is overkill but it's hard to know how many user types will be wanted. As for the size short, is a tag with a size that uses all those bits too big? Maybe. But let's say we use two bytes overall. 4 for type is only 16 tag types. That leaves 12 bits left for length. That's 4k max tag length. Too small for some uses by far. There is a whole file optimization similar to what's done with memstoreTS. Could also consider a block header but we have not done this as of yet because encoders will handle tags in their own way. > Address review comments in HBASE-8496 > ------------------------------------- > > Key: HBASE-9816 > URL: https://issues.apache.org/jira/browse/HBASE-9816 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 0.98.0 > > > This JIRA would be used to address the review comments in HBASE-8496. Any > more comments would be addressed and committed as part of this. There are > already few comments from Stack on the RB. > https://reviews.apache.org/r/13311/ -- This message was sent by Atlassian JIRA (v6.1#6144)