[
https://issues.apache.org/jira/browse/HBASE-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809383#comment-13809383
]
Ted Yu commented on HBASE-9000:
-------------------------------
Some comments on the benchmark:
Please add Apache license header.
Add class javadoc for MemStoreReseekBenchmark.
{code}
+ private final Random random = new Random();
{code}
Can you use seed for the above call and log the value of the seed ?
{code}
+ private List<byte[]> rows; private List<byte[]> qualifiers;
{code}
Please put the above on two lines.
{code}
+ boolean ok = scanner.reseek(key);
+ if (!ok) {
+ throw new AssertionError("!ok");
{code}
Please print the key which caused assertion.
> Linear reseek in Memstore
> -------------------------
>
> Key: HBASE-9000
> URL: https://issues.apache.org/jira/browse/HBASE-9000
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.89-fb
> Reporter: Shane Hogan
> Priority: Minor
> Fix For: 0.89-fb
>
> Attachments: hbase-9000-benchmark-program.patch,
> hbase-9000-port-fb.patch
>
>
> This is to address the linear reseek in MemStoreScanner. Currently reseek
> iterates over the kvset and the snapshot linearly by just calling next
> repeatedly. The new solution is to do this linear seek up to a configurable
> maximum amount of times then if the seek is not yet complete fall back to
> logarithmic seek.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
