[ https://issues.apache.org/jira/browse/HBASE-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809467#comment-13809467 ]
ramkrishna.s.vasudevan commented on HBASE-9045: ----------------------------------------------- Sorry for being late into this, Just thinking on this do we always need to compress tag by tag or sometimes the entire tag part can be compressed. In some cases compressing the entire thing would be simple and would be better for that scneario I feel. That would imapct the WAL compresssion also then. Can do it based on configuration? We are having two flavours of compress and uncompress tags. I can get the meaning when combined with the WAL tag compression. {code} Context that holds the dictionary for Tag compression and doing the compress/uncompress. This * will be used for compressing tags while writing into WALs. {code} Can change this javadoc in TagCompressionContext. In what scenario can a byte buffer be not backed by an array? {code} if (in.hasArray()) {code} Is it because in some cases we are passing just an empty bytebuffer? Looks good overall. > Support Dictionary based Tag compression in HFiles > -------------------------------------------------- > > Key: HBASE-9045 > URL: https://issues.apache.org/jira/browse/HBASE-9045 > Project: HBase > Issue Type: Sub-task > Affects Versions: 0.98.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.98.0 > > Attachments: HBASE-9045.patch, HBASE-9045_V2.patch > > > Along with the DataBlockEncoding algorithms, Dictionary based Tag compression > can be done -- This message was sent by Atlassian JIRA (v6.1#6144)