[ https://issues.apache.org/jira/browse/HBASE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810848#comment-13810848 ]
Hadoop QA commented on HBASE-9867: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12611521/9867.096.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7695//console This message is automatically generated. > Save on array copies with a subclass of LiteralByteString > --------------------------------------------------------- > > Key: HBASE-9867 > URL: https://issues.apache.org/jira/browse/HBASE-9867 > Project: HBase > Issue Type: Improvement > Components: Protobufs > Affects Versions: 0.96.0 > Reporter: stack > Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9867.096.txt, 9867.txt, 9867.txt, 9867v2.txt > > > Any time we add a byte array to a protobuf, it'll copy the byte array. > I was playing with the client and noticed how a bunch of CPU and copying was > being done just to copy basic arrays doing pb construction. I started to > look at ByteString and then remembered a class Benoit sent me a while back > that I did not understand from his new AsyncHBase. After looking in > ByteString it made now sense. So, rather than copy byte arrays everywhere, > do a version of a ByteString that instead wraps the array. -- This message was sent by Atlassian JIRA (v6.1#6144)