[
https://issues.apache.org/jira/browse/HBASE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811113#comment-13811113
]
Liang Xie commented on HBASE-9855:
----------------------------------
>From
>https://builds.apache.org/job/PreCommit-HBASE-Build/7698//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
> and
>https://builds.apache.org/job/PreCommit-HBASE-Build/7698//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html,
> i could not find any warnings related with the new changed
>files(BlockCacheKey/BucketCache/ConcurrentIndex), so to me now , this jira
>is OK for findbug checking.
> evictBlocksByHfileName improvement for bucket cache
> ---------------------------------------------------
>
> Key: HBASE-9855
> URL: https://issues.apache.org/jira/browse/HBASE-9855
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.98.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HBase-9855-v2.txt, HBase-9855-v3.txt, HBase-9855.txt
>
>
> In deed, it comes from fb's l2 cache by [~avf]'s nice work, i just did a
> simple backport here. It could improve a linear-time search through the whole
> cache map into a log-access-time map search.
> I did a small bench, showed it brings a bit gc overhead, but considering the
> evict on close triggered by frequent compaction activity, seems reasonable?
> and i thought bring a "evictOnClose" config into BucketCache ctor and only
> put/remove the new index map while evictOnClose is true, seems this value
> could be set by each family schema, but BucketCache is a global instance not
> per each family, so just ignore it rightnow...
--
This message was sent by Atlassian JIRA
(v6.1#6144)
