[ 
https://issues.apache.org/jira/browse/HBASE-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052852#comment-13052852
 ] 

Jean-Daniel Cryans commented on HBASE-4010:
-------------------------------------------

On the v2 patch:

 - It seems the new createTable method is mostly copy pasted from the other, 
refactor?
 - Same in MetaEditor.
 - On the batch Put... I would almost prefer not doing multiple batches since 
in 0.92 we don't even carry the HTD in the HRI meaning that the edits are 
really small.

Is it passing all unit tests (that are currently green)?

> HMaster.createTable could be heavily optimized
> ----------------------------------------------
>
>                 Key: HBASE-4010
>                 URL: https://issues.apache.org/jira/browse/HBASE-4010
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.3
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: 4010-v2.txt, 4010.txt
>
>
> Looking at the createTable method in HMaster (the one that's private), we 
> seem to be very inefficient:
>  - We set the enabled flag for the table for every region (should be done 
> only once).
>  - Every time we create a new region we create a new HLog and then close it 
> (reuse one instead or see if it's really necessary).
>  - We do one RPC to .META. per region (we should batch put).
> This should provide drastic speedups even for those creating tables with just 
> 50 regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to