[
https://issues.apache.org/jira/browse/HBASE-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819487#comment-13819487
]
stack commented on HBASE-9829:
------------------------------
+1 on cleanup of logging.
Nit:
On commit make the thread names shorter:
- t.setName(n + "-largeCompactions-" + System.currentTimeMillis());
+ t.setName(n + "-longCompactions-" + System.currentTimeMillis());
When they log, long thread names right-shifts it all.
Could we do better than current time milliis? Millis like this are pretty
opaque. A HH:MM:SS has same rough size but easier read.
Why change from large to long and from small to short? Is it actually
difference between short and long and the original variables were misnamed?
They run for short time or is it that they choose a small amount of data to
compact? If more the latter, would original names be better? SIze or time
based?
There seems to be all files and major compaction. it is the case that when we
select all files, we run a major compaction still? This is plain in the
logging?
Thanks Sergey.
> make the compaction logging less confusing
> ------------------------------------------
>
> Key: HBASE-9829
> URL: https://issues.apache.org/jira/browse/HBASE-9829
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Attachments: HBASE-9829.patch
>
>
> 1) One of the most popular question from HBase users has got to be "I have
> scheduled major compactions to run once per week, why are there so many".
> We need to somehow tell the user, wherever we log that there is a "major"
> compaction, whether it's a major compaction because that's what was in the
> request (from regular major compaction or user request), or was it just
> promoted because it took all files. Esp. the latter should be clear.
> 2) small vs large compaction threads and minor vs major compactions is
> confusing. Maybe the threads can be named short and long compactions.
> We
--
This message was sent by Atlassian JIRA
(v6.1#6144)
