[
https://issues.apache.org/jira/browse/HBASE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821083#comment-13821083
]
stack commented on HBASE-5945:
------------------------------
Stuff is very different now. The attached patch gets the big idea. The other
fixups in hbase-5495.txt no longer apply. There is no more a
HbaseObjectWritable nor Invocation. The hand-making of pbs I did not do but
picked up the creation of CodedOutputStream using byte array to avoid it
internally assigning buffer. The RPCServer changes make sense still a little
complicated by sasl wrapping but we still get a win I believe.
Will try and do a bit of benchmarking...
> Reduce buffer copies in IPC server response path
> ------------------------------------------------
>
> Key: HBASE-5945
> URL: https://issues.apache.org/jira/browse/HBASE-5945
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Affects Versions: 0.95.2
> Reporter: Todd Lipcon
> Assignee: stack
> Fix For: 0.96.1
>
> Attachments: 5945-in-progress.2.1.patch, 5945-in-progress.2.patch,
> 5945-in-progress.patch, 5945v2.txt, buffer-copies.txt, even-fewer-copies.txt,
> hbase-5495.txt
>
>
> The new PB code is sloppy with buffers and makes several needless copies.
> This increases GC time a lot. A few simple changes can cut this back down.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
