[ https://issues.apache.org/jira/browse/HBASE-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822507#comment-13822507 ]
Hudson commented on HBASE-4654: ------------------------------- SUCCESS: Integrated in HBase-0.94 #1201 (See [https://builds.apache.org/job/HBase-0.94/1201/]) HBASE-4654 [replication] Add a check to make sure we don't replicate to ourselves (Demai Ni) (larsh: rev 1541806) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > [replication] Add a check to make sure we don't replicate to ourselves > ---------------------------------------------------------------------- > > Key: HBASE-4654 > URL: https://issues.apache.org/jira/browse/HBASE-4654 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.90.4 > Reporter: Jean-Daniel Cryans > Assignee: Demai Ni > Fix For: 0.98.0, 0.96.1, 0.94.14 > > Attachments: 4654-trunk.txt, HBASE-4654-0.94-v0.patch, > HBASE-4654-0.96-v0.patch, HBASE-4654-trunk-v0.patch, > HBASE-4654-trunk-v0.patch, HBASE-4654-trunk-v0.patch > > > It's currently possible to add a peer for replication and point it to the > local cluster, which I believe could very well happen for those like us that > use only one ZK ensemble per DC so that only the root znode changes when you > want to set up replication intra-DC. > I don't think comparing just the cluster ID would be enough because you would > normally use a different one for another cluster and nothing will block you > from pointing elsewhere. > Comparing the ZK ensemble address doesn't work either when you have multiple > DNS entries that point at the same place. > I think this could be resolved by looking up the master address in the > relevant znode as it should be exactly the same thing in the case where you > have the same cluster. -- This message was sent by Atlassian JIRA (v6.1#6144)