[ 
https://issues.apache.org/jira/browse/HBASE-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826643#comment-13826643
 ] 

Nicolas Liochon commented on HBASE-10001:
-----------------------------------------

Actually, if I read correctly the code in HRegion, just marking the operations 
as success as I do in the v1 is enough:

{code}
      // ------------------------------------
      // STEP 4. Build WAL edit
      // ----------------------------------
      boolean hasWalAppends = false;
      Durability durability = Durability.USE_DEFAULT;
      for (int i = firstIndex; i < lastIndexExclusive; i++) {
        // Skip puts that were determined to be invalid during preprocessing
        if (batchOp.retCodeDetails[i].getOperationStatusCode()
            != OperationStatusCode.NOT_RUN) {           // 
<<<<<<<<<<<<<<<========= if the copro marked it as SUCCESS we don't write it to 
the WAL.
          continue;
        }
{code}

> Add a coprocessor to help testing the performances without taking into 
> account the i/o
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-10001
>                 URL: https://issues.apache.org/jira/browse/HBASE-10001
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.98.0, 0.96.0, 0.94.13
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.1, 0.94.15
>
>         Attachments: 10001.v1.patch
>
>
> We have a mockup to test only the client. If we want to include the network, 
> without beeing limited by the i/o, we don't have much tools.
> This coprocessor helps to test this.
> I put it in the main code as to make it usable without adding a jar...
> I don't think it's possible avoid the WAL writes in the coprocessors. It 
> would be great to have it to simplify the test with any kind of client (i.e. 
> w/o changing the durability).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to