[ https://issues.apache.org/jira/browse/HBASE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826982#comment-13826982 ]
Ted Yu commented on HBASE-9969: ------------------------------- I couldn't compile Matt's patch: {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure: [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java:[46,49] cannot find symbol [ERROR] symbol: class BenchmarkableKeyValueHeap [ERROR] implements KeyValueScanner, InternalScanner, BenchmarkableKeyValueHeap { [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScannerHeap.java:[45,49] cannot find symbol [ERROR] symbol: class BenchmarkableKeyValueHeap [ERROR] implements KeyValueScanner, InternalScanner, BenchmarkableKeyValueHeap{ [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LoserTreeKeyValueHeap.java:[48,49] cannot find symbol [ERROR] symbol: class BenchmarkableKeyValueHeap [ERROR] implements KeyValueScanner, InternalScanner, BenchmarkableKeyValueHeap { [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java:[394,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java:[399,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java:[404,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java:[409,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java:[414,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScannerHeap.java:[399,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScannerHeap.java:[404,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScannerHeap.java:[409,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScannerHeap.java:[414,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScannerHeap.java:[419,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LoserTreeKeyValueHeap.java:[354,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LoserTreeKeyValueHeap.java:[359,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LoserTreeKeyValueHeap.java:[364,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LoserTreeKeyValueHeap.java:[369,2] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LoserTreeKeyValueHeap.java:[374,2] method does not override or implement a method from a supertype {code} > Improve KeyValueHeap using loser tree > ------------------------------------- > > Key: HBASE-9969 > URL: https://issues.apache.org/jira/browse/HBASE-9969 > Project: HBase > Issue Type: Improvement > Components: Performance, regionserver > Reporter: Chao Shi > Assignee: Chao Shi > Fix For: 0.98.0, 0.96.1 > > Attachments: 9969-0.94.txt, KeyValueHeapBenchmark_v1.ods, > hbase-9969-pq-v1.patch, hbase-9969-v2.patch, hbase-9969-v3.patch, > hbase-9969.patch, hbase-9969.patch, kvheap-benchmark.png, kvheap-benchmark.txt > > > LoserTree is the better data structure than binary heap. It saves half of the > comparisons on each next(), though the time complexity is on O(logN). > Currently A scan or get will go through two KeyValueHeaps, one is merging KVs > read from multiple HFiles in a single store, the other is merging results > from multiple stores. This patch should improve the both cases whenever CPU > is the bottleneck (e.g. scan with filter over cached blocks, HBASE-9811). > All of the optimization work is done in KeyValueHeap and does not change its > public interfaces. The new code looks more cleaner and simpler to understand. -- This message was sent by Atlassian JIRA (v6.1#6144)