[ 
https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837471#comment-13837471
 ] 

Liu Shaohui commented on HBASE-10048:
-------------------------------------

{quote}
(I'd avoid doing the "numLogs +1" stuff, as it looks brittle). IMO, it is OKAY 
to show the rolled WALs and leave out the current one. And, name the metrics 
accordingly. What do you think Liu Shaohui?
{quote}
I agree. thx.
I will update the patch later.


> Add hlog number metric in regionserver
> --------------------------------------
>
>                 Key: HBASE-10048
>                 URL: https://issues.apache.org/jira/browse/HBASE-10048
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, 
> HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, 
> HBASE-10048-trunk-v3.diff
>
>
> Add hlog number metric in regionserver. 
> We can use this metric to alert about memstore flush because of too many 
> hlogs.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to