[ 
https://issues.apache.org/jira/browse/HBASE-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841971#comment-13841971
 ] 

Hadoop QA commented on HBASE-9892:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12617512/HBASE-9892-trunk-v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8082//console

This message is automatically generated.

> Add info port to ServerName to support multi instances in a node
> ----------------------------------------------------------------
>
>                 Key: HBASE-9892
>                 URL: https://issues.apache.org/jira/browse/HBASE-9892
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.1, 0.99.0
>
>         Attachments: HBASE-9892-0.94-v1.diff, HBASE-9892-0.94-v2.diff, 
> HBASE-9892-0.94-v3.diff, HBASE-9892-0.94-v4.diff, HBASE-9892-0.94-v5.diff, 
> HBASE-9892-trunk-v1.diff, HBASE-9892-trunk-v1.patch, 
> HBASE-9892-trunk-v1.patch, HBASE-9892-v5.txt
>
>
> The full GC time of  regionserver with big heap(> 30G ) usually  can not be 
> controlled in 30s. At the same time, the servers with 64G memory are normal. 
> So we try to deploy multi rs instances(2-3 ) in a single node and the heap of 
> each rs is about 20G ~ 24G.
> Most of the things works fine, except the hbase web ui. The master get the RS 
> info port from conf, which is suitable for this situation of multi rs  
> instances in a node. So we add info port to ServerName.
> a. at the startup, rs report it's info port to Hmaster.
> b, For root region, rs write the servername with info port ro the zookeeper 
> root-region-server node.
> c, For meta regions, rs write the servername with info port to root region 
> d. For user regions,  rs write the servername with info port to meta regions 
> So hmaster and client can get info port from the servername.
> To test this feature, I change the rs num from 1 to 3 in standalone mode, so 
> we can test it in standalone mode,
> I think Hoya(hbase on yarn) will encounter the same problem.  Anyone knows 
> how Hoya handle this problem?
> PS: There are  different formats for servername in zk node and meta table, i 
> think we need to unify it and refactor the code.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to