[ https://issues.apache.org/jira/browse/HBASE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850237#comment-13850237 ]
Hadoop QA commented on HBASE-10148: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619042/HBASE-10148_V2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//console This message is automatically generated. > [VisibilityController] Tolerate regions in recovery > --------------------------------------------------- > > Key: HBASE-10148 > URL: https://issues.apache.org/jira/browse/HBASE-10148 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Andrew Purtell > Assignee: Anoop Sam John > Priority: Blocker > Fix For: 0.98.0 > > Attachments: HBASE-10148.patch, HBASE-10148_V2.patch > > > Ted Yu reports that enabling distributed log replay by default, like: > {noformat} > Index: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > =================================================================== > --- hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > (revision 1550575) > +++ hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > (working copy) > @@ -794,7 +794,7 @@ > /** Conf key that enables unflushed WAL edits directly being replayed to > region servers */ > public static final String DISTRIBUTED_LOG_REPLAY_KEY = > "hbase.master.distributed.log.replay"; > - public static final boolean DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG = false; > + public static final boolean DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG = true; > public static final String DISALLOW_WRITES_IN_RECOVERING = > "hbase.regionserver.disallow.writes.when.recovering"; > public static final boolean DEFAULT_DISALLOW_WRITES_IN_RECOVERING_CONFIG = > false; > {noformat} > causes TestVisibilityController#testAddVisibilityLabelsOnRSRestart to fail. > It reveals an issue with label operations if the label table is recovering: > {noformat} > 2013-12-12 14:53:53,133 DEBUG [RpcServer.handler=2,port=58108] > visibility.VisibilityController(1046): Adding the label XYZ2013-12-12 > 14:53:53,137 ERROR [RpcServer.handler=2,port=58108] > visibility.VisibilityController(1074): > org.apache.hadoop.hbase.exceptions.RegionInRecoveryException: > hbase:labels,,1386888826648.f14a399ba85cbb42c2c3b7547bf17c65. is recovering > 2013-12-12 14:53:53,151 DEBUG [main] visibility.TestVisibilityLabels(405): > response from addLabels: result { > exception { > name: "org.apache.hadoop.hbase.exceptions.RegionInRecoveryException" > value: "org.apache.hadoop.hbase.exceptions.RegionInRecoveryException: > hbase:labels,,1386888826648.f14a399ba85cbb42c2c3b7547bf17c65. is recovering > at > org.apache.hadoop.hbase.regionserver.HRegion.startRegionOperation(HRegion.java:5555) > at > org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1763) at > org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1749) at > org.apache.hadoop.hbase.security.visibility.VisibilityController.getExistingLabelsWithAuths(VisibilityController.java:1096) > at > org.apache.hadoop.hbase.security.visibility.VisibilityController.postBatchMutate(VisibilityController.java:672)" > {noformat} > Should we try to ride over this? -- This message was sent by Atlassian JIRA (v6.1.4#6159)