[ https://issues.apache.org/jira/browse/HBASE-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852570#comment-13852570 ]
Anoop Sam John edited comment on HBASE-9346 at 12/19/13 3:45 AM: ----------------------------------------------------------------- {quote} + if (reader.getFirstKey() != null) if ((storeFirstKey == null) + || (comparator.compare(storeFirstKey, reader.getFirstKey()) < 0)) + storeFirstKey = reader.getFirstKey(); {quote} Here you want to get the smallest first key across all files right? Does this compare <0 gives that? Similar below with storeLastKey Two ifs in one line.. Bit difficult to read.. Can you format that pls? void setRegionBoundaries() -> Method name can be better? say setRegionBoundariesCheck? Who calls this setter? + ByteArrayComparator comparator = new ByteArrayComparator(); Can directly use Bytes.BYTES_COMPARATOR ? was (Author: anoop.hbase): {quote} + if (reader.getFirstKey() != null) if ((storeFirstKey == null) + || (comparator.compare(storeFirstKey, reader.getFirstKey()) < 0)) + storeFirstKey = reader.getFirstKey(); {quote} Here you want to get the smallest first key across all files right? Does this compare <0 gives that? Two ifs in one line.. Bit difficult to read.. Can you format that pls? void setRegionBoundaries() -> Method name can be better? say setRegionBoundariesCheck? Who calls this setter? + ByteArrayComparator comparator = new ByteArrayComparator(); Can directly use Bytes.BYTES_COMPARATOR ? > HBCK should provide an option to check if regions boundaries are the same in > META and in stores. > ------------------------------------------------------------------------------------------------ > > Key: HBASE-9346 > URL: https://issues.apache.org/jira/browse/HBASE-9346 > Project: HBase > Issue Type: Bug > Components: hbck > Affects Versions: 0.94.14, 0.98.1, 0.99.0, 0.96.1.1 > Reporter: Jean-Marc Spaggiari > Assignee: Jean-Marc Spaggiari > Attachments: HBASE-9346-v0-0.94.patch, HBASE-9346-v1-trunk.patch, > HBASE-9346-v2-trunk.patch, HBASE-9346-v3-trunk.patch, > HBASE-9346-v4-trunk.patch, HBASE-9346-v5-trunk.patch, > HBASE-9346-v6-trunk.patch > > > If META don't have the same region boundaries as the stores files, writes and > read might go to the wrong place. We need to provide a way to check that > withing HBCK. -- This message was sent by Atlassian JIRA (v6.1.4#6159)