[
https://issues.apache.org/jira/browse/HBASE-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853294#comment-13853294
]
Jonathan Hsieh commented on HBASE-10142:
----------------------------------------
Also important.to note is that prior to the patch, the ramification of the race
is a extra request to roll the log. This a performance penalty and not a
correctness problem.
Sounds like this would be worth backporting for 0.96.2. Ideally there would be
comments where the lock is defined that explains why the lock exists and would
explain why it is taken at certain places.
> TestLogRolling#testLogRollOnDatanodeDeath test failure
> ------------------------------------------------------
>
> Key: HBASE-10142
> URL: https://issues.apache.org/jira/browse/HBASE-10142
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0, 0.99.0
> Reporter: Andrew Purtell
> Assignee: Ted Yu
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10142-v1.txt
>
>
> This is a demanding unit test, which fails fairly often as software versions
> (JVM, Hadoop) and system load change. Currently when testing 0.98 branch I
> see this failure:
> {noformat}
> Failed tests:
> testLogRollOnDatanodeDeath(org.apache.hadoop.hbase.regionserver.wal.TestLogRolling):
> LowReplication Roller should've been disabled, current replication=1
> {noformat}
> Could be a timing issue after the recent switch to Hadoop 2 as default
> build/test profile. Let's see if more leniency makes sense and if it can
> stabilize the test before disabling it.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
