[ 
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858929#comment-13858929
 ] 

stack commented on HBASE-10255:
-------------------------------

Your interpretation of my remark is off.  You apply a statement of mine about 
an action of yours -- adding a guava class to hbase core to accommodate and 
upgrade -- from a different issue to a completely different context, one that 
is of the past and motivated likely because LIS is protected in pb.... Nor did 
I ask you to go through code base looking for offenders.

So, no performance compare though you have changed a critical class?

> Remove dependency on LimitInputStream
> -------------------------------------
>
>                 Key: HBASE-10255
>                 URL: https://issues.apache.org/jira/browse/HBASE-10255
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10255-v1.txt, 10255-v2.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed 
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream, 
> long) instead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to