[ 
https://issues.apache.org/jira/browse/HBASE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867321#comment-13867321
 ] 

Lars Hofhansl commented on HBASE-10281:
---------------------------------------

So looking at the failure, I do not actually understand what the test is try to 
do.
The offending part is here (in doTestFlushCommits called from 
testFlushCommitsNoAbort):
{code}
    for (JVMClusterUtil.RegionServerThread t: liveRSs) {
      int regions = t.getRegionServer().getOnlineRegions().size();
      Assert.assertTrue("Count of regions=" + regions, regions > 10);
    }
{code}

So this verifies that each RS has at least 10 regions. We start out with 
creating 25 regions, at we have two RSs in this test. So this part would only 
pass if the cluster is nicely balanced. (It tries to balance before each test, 
but either that is not finished or it is not doing it perfectly at all time).

In any case, we're not testing the balancer. So in the end we only need to 
check that we have at least 25 regions - *if* we want to check that at all. 
Before we get here we have verified that all rows are expecting are in fact 
present.


> TestMultiParallel.testFlushCommitsNoAbort fails frequently in 0.94
> ------------------------------------------------------------------
>
>                 Key: HBASE-10281
>                 URL: https://issues.apache.org/jira/browse/HBASE-10281
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>
> Here's a run (with JDK7, but I've seen it with 0.96 as well).
> https://builds.apache.org/job/HBase-0.94-JDK7/17/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/
> {code}
> Error Message
> Count of regions=10
> Stacktrace
> java.lang.AssertionError: Count of regions=10
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at 
> org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:289)
>       at 
> org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsNoAbort(TestMultiParallel.java:222)
>         ...
> {code}
> This might be a side-effect of: HBASE-10259



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to