[ https://issues.apache.org/jira/browse/HBASE-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871456#comment-13871456 ]
Hudson commented on HBASE-10324: -------------------------------- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #53 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/53/]) HBASE-10324 refactor deferred-log-flush/Durability related interface/code/naming to align with changed semantic of the new write thread model (Tedyu: rev 1557939) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestDurability.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java * /hbase/trunk/hbase-shell/src/main/ruby/hbase/admin.rb > refactor deferred-log-flush/Durability related interface/code/naming to align > with changed semantic of the new write thread model > --------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-10324 > URL: https://issues.apache.org/jira/browse/HBASE-10324 > Project: HBase > Issue Type: Improvement > Components: Client, regionserver > Reporter: Feng Honghua > Assignee: Feng Honghua > Fix For: 0.98.0, 0.99.0 > > Attachments: 10324-trunk_v3.patch, HBASE-10324-trunk_v0.patch, > HBASE-10324-trunk_v1.patch, HBASE-10324-trunk_v2.patch > > > By the new write thread model introduced by > [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755], some > deferred-log-flush/Durability API/code/names should be change accordingly: > 1. no timer-triggered deferred-log-flush since flush is always done by async > threads, so configuration 'hbase.regionserver.optionallogflushinterval' is no > longer needed > 2. the async writer-syncer-notifier threads will always be triggered > implicitly, this semantic is that it always holds that > 'hbase.regionserver.optionallogflushinterval' > 0, so deferredLogSyncDisabled > in HRegion.java which affects durability behavior should always be false > 3. what HTableDescriptor.isDeferredLogFlush really means is the write can > return without waiting for the sync is done, so the interface name should be > changed to isAsyncLogFlush/setAsyncLogFlush to reflect their real meaning -- This message was sent by Atlassian JIRA (v6.1.5#6160)