[ 
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871598#comment-13871598
 ] 

ramkrishna.s.vasudevan commented on HBASE-10322:
------------------------------------------------

bq.The rock bottom simplest way to do this is to just not support tags in RPC 
codecs
But from client to server it should be supported and in the WAL part it should 
be supported both ways.  for export tool alone how to identify that the client 
is doing an export?  We ended up discussing all this and came up with a patch. 
Another suggestion atleast to avoid changes to the codec part is to have an 
init() in the Codec.java.  So once the codec is instantiated we could set this 
flag as true or false based on client or server.  
So for server if the flag says false then the tags are not sent back but for 
client it is always written.  This involves changes to the Codec.java, 
introduces an init() method and decision is taken based on what is set on this 
init method.  We have a patch for this, but again it does not do completely 
what Stack wants.  Only a part of what Stack wants is solved by that. 
Anyway the User related things are just same as in the exisitng patch.  This 
whole stripping of tags is really tricky.


> Strip tags from KV while sending back to client on reads
> --------------------------------------------------------
>
>                 Key: HBASE-10322
>                 URL: https://issues.apache.org/jira/browse/HBASE-10322
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10322.patch
>
>
> Right now we have some inconsistency wrt sending back tags on read. We do 
> this in scan when using Java client(Codec based cell block encoding). But 
> during a Get operation or when a pure PB based Scan comes we are not sending 
> back the tags.  So any of the below fix we have to do
> 1. Send back tags in missing cases also. But sending back visibility 
> expression/ cell ACL is not correct.
> 2. Don't send back tags in any case. This will a problem when a tool like 
> ExportTool use the scan to export the table data. We will miss exporting the 
> cell visibility/ACL.
> 3. Send back tags based on some condition. It has to be per scan basis. 
> Simplest way is pass some kind of attribute in Scan which says whether to 
> send back tags or not. But believing some thing what scan specifies might not 
> be correct IMO. Then comes the way of checking the user who is doing the 
> scan. When a HBase super user doing the scan then only send back tags. So 
> when a case comes like Export Tool's the execution should happen from a super 
> user.
> So IMO we should go with #3.
> Patch coming soon.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to