[
https://issues.apache.org/jira/browse/HBASE-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871871#comment-13871871
]
chendihao commented on HBASE-9932:
----------------------------------
If it works for now, I don't think we have to remove the functional code.
[~jeffreyz] Can you explain what problem it will cause during recovering the
master?
I'm working on this and have the same feeling about that there are potential
issues when HMaster disconnected or session expired(refer to HBASE-10345).
Removing the recovery handling is the simplest solution but we should
understand underlying problem firstly.
> Remove Master Recovery handling when ZK session expired
> -------------------------------------------------------
>
> Key: HBASE-9932
> URL: https://issues.apache.org/jira/browse/HBASE-9932
> Project: HBase
> Issue Type: Brainstorming
> Reporter: Jeffrey Zhong
>
> Currently we use HMaster#tryRecoveringExpiredZKSession to allow master
> recovery from a ZK session expired error. While this triggers to initialize
> HMaster partially, it is error prone because it's hard to guarantee the half
> initialized master is in correct state. I found several times already that
> the registered ZK listeners are different before & after a fail over.
> Since we already have HA support, I'm proposing to remove this part handling.
> Though we have a configuration setting "fail.fast.expired.active.master" to
> skip the logic, why not go one stop further to clean the master code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
