[
https://issues.apache.org/jira/browse/HBASE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875053#comment-13875053
]
stack commented on HBASE-10289:
-------------------------------
bq. The idea behind this patch is to give a option to user to control the ports
used by JMX server.
Great.
These defines are only used in one place so I'd move them there rather than add
them to HConstants:
+ /** Configuration key for "rmi registry port" */
+ public static final String RMI_REGISTRY_PORT = ".rmi.registry.port";
+
+ /** Configuration key for "rmi connector port" */
+ public static final String RMI_CONNECTOR_PORT = ".rmi.connector.port";
+
+ /** Configuration key for "rmi registry ip" */
+ public static final String RMI_REGISTRY_IP = ".rmi.registry.ip";
+
+ /** Configuration key for "rmi connector name" */
+ public static final String RMI_REGISTRY_CONNECTORNAME =
".rmi.registry.connectorname";
+
+ /** Default rmi registry ip value */
+ public static final String RMI_REGISTRY_IP_DEFAULT = "127.0.0.1";
JMXServer is missing an apache license (see adjacent .java files for how). I
can add the audience annotation on commit.
Class could do with a comment -- a synopsis of the comments you made above
explaining this feature to me would do nicely.
How does your server get started and shutdown? It should be embedded in Master
and RegionServer?
> Avoid random port usage by default JMX Server. Create Custome JMX server
> ------------------------------------------------------------------------
>
> Key: HBASE-10289
> URL: https://issues.apache.org/jira/browse/HBASE-10289
> Project: HBase
> Issue Type: Improvement
> Reporter: nijel
> Priority: Minor
> Attachments: HBASE-10289.patch
>
>
> If we enable JMX MBean server for HMaster or Region server through VM
> arguments, the process will use one random which we cannot configure.
> This can be a problem if that random port is configured for some other
> service.
> This issue can be avoided by supporting a custom JMX Server.
> The ports can be configured. If there is no ports configured, it will
> continue the same way as now.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
