[ 
https://issues.apache.org/jira/browse/HBASE-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877435#comment-13877435
 ] 

Feng Honghua commented on HBASE-10213:
--------------------------------------

bq.However, it is not clear enough to know how many bytes replicating to peer 
cluster from these metrics. In production environment, it may be important to 
know the size of replicating data per second
the intention of this jira is good:-), but by examining the patch:
{code}metrics.incrLogReadInByes(this.repLogReader.getPosition() - 
positionBeforeRead);{code}
the metric above only reflects the log read/parse rate, not the desired 
replicating data to peer cluster rate, since the read/parsed log files may 
contain many kvs from column-families with replication scope=0 which will be 
filtered out and removed from the entries list before the real replicating to 
peer cluster occurs...
why not use currentSize, the size of all entries which will be really 
replicated to the peer cluster?

> Add read log size per second metrics for replication source
> -----------------------------------------------------------
>
>                 Key: HBASE-10213
>                 URL: https://issues.apache.org/jira/browse/HBASE-10213
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics, Replication
>    Affects Versions: 0.94.14
>            Reporter: cuijianwei
>            Assignee: cuijianwei
>            Priority: Minor
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10213-trunk-addendum-1.patch, HBASE-10213-0.94-v1.patch, 
> HBASE-10213-0.94-v2.patch, HBASE-10213-trunk-v1.patch
>
>
> The current metrics of replication source contain logEditsReadRate, 
> shippedBatchesRate, etc, which could indicate how fast the data replicated to 
> peer cluster to some extent. However, it is not clear enough to know how many 
> bytes replicating to peer cluster from these metrics. In production 
> environment, it may be important to know the size of replicating data per 
> second because the services may be affected if the network become busy.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to