[ https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878527#comment-13878527 ]
Hadoop QA commented on HBASE-10395: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624315/HBASE-10395-trunk-v3.patch against trunk revision . ATTACHMENT ID: 12624315 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testHBase3583(TestRegionObserverInterface.java:244) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8494//console This message is automatically generated. > endTime won't be set in VerifyReplication if startTime is not set > ----------------------------------------------------------------- > > Key: HBASE-10395 > URL: https://issues.apache.org/jira/browse/HBASE-10395 > Project: HBase > Issue Type: Improvement > Components: mapreduce, Replication > Affects Versions: 0.94.16 > Reporter: cuijianwei > Assignee: cuijianwei > Priority: Minor > Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, > HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, > HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch > > > In VerifyReplication, we may set startTime and endTime to restrict the data > to verfiy. However, the endTime won't be set in the program if we only pass > endTime without startTime in command line argument. The reason is the > following code: > {code} > if (startTime != 0) { > scan.setTimeRange(startTime, > endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime); > } > {code} > The code will ignore endTime setting when not passing startTime in command > line argument. Another place needs to improvement is the help message as > follows: > {code} > System.err.println(" stoprow end of the row"); > {code} > However, the program actually use "endrow" to parse the arguments: > {code} > final String endTimeArgKey = "--endtime="; > if (cmd.startsWith(endTimeArgKey)) { > endTime = Long.parseLong(cmd.substring(endTimeArgKey.length())); > continue; > } > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)