[ 
https://issues.apache.org/jira/browse/HBASE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889772#comment-13889772
 ] 

Andrew Purtell commented on HBASE-10454:
----------------------------------------

PrefixTree doesn't compress tags, it encodes them using ... a prefix tree. This 
is not tag compression using the (currently broken) custom dictionary 
compression scheme employed by HFile. We need to differentiate. I argue the 
patch here is not needed and confusing. Just update the documentation on prefix 
tree to discuss how it handles tags, if that is missing.

-0 on patch

> TAGS_COMPRESSED file info is wrong in HFiles when PrefixTree encoding is used
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-10454
>                 URL: https://issues.apache.org/jira/browse/HBASE-10454
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.98.0
>
>         Attachments: HBASE-10454.patch
>
>
> We always encode tags in case of Prefix tree now and so the code path, while 
> decoding, not checking what is there in FileInfo. So functionally no issues 
> now.
> If we do HBASE-10453 this change will be very important to make sure BC for 
> old files.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to