[
https://issues.apache.org/jira/browse/HBASE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890360#comment-13890360
]
Anoop Sam John edited comment on HBASE-10454 at 2/4/14 5:36 AM:
----------------------------------------------------------------
With that compressed file info, I mean to add in the Prefix tree encoded HFiles
the info, whether the file is containing tags as encoded or not. (Just see
comment in HBASE-10453) As per the discussion there, no need to do that
encoding condition based. Tag compression will happen only in encoded files
for encoders other than Prefix tree. Fine. Will attach a patch which
contains only the tag presence part.
was (Author: anoop.hbase):
With that compressed file info, I mean to add in the Prefix tree encoded HFiles
the info, whether the file is containing tags as encoded or not. (Just see
comment in HBASE-10454) As per the discussion there, no need to do that
encoding condition based. Tag compression will happen only in encoded files
for encoders other than Prefix tree. Fine. Will attach a patch which
contains only the tag presence part.
> Tags presence file info can be wrong in HFiles when PrefixTree encoding is
> used
> -------------------------------------------------------------------------------
>
> Key: HBASE-10454
> URL: https://issues.apache.org/jira/browse/HBASE-10454
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Minor
> Fix For: 0.98.0
>
> Attachments: HBASE-10454.patch, HBASE-10454_V2.patch
>
>
> We always encode tags in case of Prefix tree now and so the code path, while
> decoding, not checking what is there in FileInfo. So functionally no issues
> now.
> If we do HBASE-10453 this change will be very important to make sure BC for
> old files.
> We use the file info MAX_TAGS_LEN to know the presence of tags in a file. In
> case of prefix tree we always have tags in files even if all kvs have 0 tags.
> So better we can add this file info into prefix tree encoded HFiles. Now it
> get missed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
