[ https://issues.apache.org/jira/browse/HBASE-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891338#comment-13891338 ]
Jonathan Hsieh commented on HBASE-10460: ---------------------------------------- I think this should be in 0.98. Here are my two best reasons: * This patch is a "simple best effort fix" (as [~lhofhansl] mentioned) and the current implementation seems to be a going out of the way to break things. I don't see how it this one is an API cleanup (in Java convention, setters return void) and is seems to be a gratuitous compat breaking change that is easy low risk fix. * This method is in a class marked InterfaceAudience.Public and InterfaceStability.Stable. [1] If this were marked InterfaceStability.Evolving I'd be ok with the "won't do" resolution but because it is Stable we should keep this around. and allow this patch in 0.98. [1] https://github.com/apache/hbase/blob/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L82 > Return value of Scan#setSmall() should be void > ---------------------------------------------- > > Key: HBASE-10460 > URL: https://issues.apache.org/jira/browse/HBASE-10460 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 0.98.0 > > Attachments: 10460.txt > > > Aleksandr Shulman reported the following incompatibility between 0.96 and > 0.98 under the '[VOTE] The 1st HBase 0.98.0 release candidate is available > for download' thread: > {code} > Exception from testScanMeta: -> java.lang.NoSuchMethodError: > org.apache.hadoop.hbase.client.Scan.setSmall(Z)V > {code} > Return value of Scan#setSmall() should be void -- This message was sent by Atlassian JIRA (v6.1.5#6160)