[ https://issues.apache.org/jira/browse/HBASE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894460#comment-13894460 ]
Hadoop QA commented on HBASE-10480: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627590/HBASE-10480-v0.patch against trunk revision . ATTACHMENT ID: 12627590 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8628//console This message is automatically generated. > TestLogRollPeriod#testWithEdits may fail due to insufficient waiting > -------------------------------------------------------------------- > > Key: HBASE-10480 > URL: https://issues.apache.org/jira/browse/HBASE-10480 > Project: HBase > Issue Type: Test > Components: test > Reporter: Ted Yu > Assignee: Matteo Bertozzi > Priority: Minor > Attachments: HBASE-10480-v0.patch > > > The test waits for minRolls rolls by sleeping: > {code} > Thread.sleep((minRolls + 1) * LOG_ROLL_PERIOD); > {code} > However, the above wait period may not be sufficient. > See > https://builds.apache.org/job/HBase-TRUNK/4895/testReport/junit/org.apache.hadoop.hbase.regionserver.wal/TestLogRollPeriod/testWithEdits/ > : > {code} > 2014-02-06 23:02:25,710 DEBUG [RS:0;quirinus:56476.logRoller] > regionserver.LogRoller(87): Hlog roll period 4000ms elapsed > ... > 2014-02-06 23:02:30,275 DEBUG [RS:0;quirinus:56476.logRoller] > regionserver.LogRoller(87): Hlog roll period 4000ms elapsed > {code} > The interval between two successive periodic rolls was ~1.5s longer than > LOG_ROLL_PERIOD (4s) > 1.5s * 4 (minRolls-1) > 4s (LOG_ROLL_PERIOD) > This led to the test failure: > {code} > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at org.junit.Assert.assertFalse(Assert.java:74) > at > org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod.checkMinLogRolls(TestLogRollPeriod.java:168) > at > org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod.testWithEdits(TestLogRollPeriod.java:130) > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)