[ 
https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899618#comment-13899618
 ] 

Vasu Mariyala commented on HBASE-10505:
---------------------------------------

[~lhofhansl] May be this is one of the issues of HBASE-10416 ?

I think we need to fix the TestImportExport.testWithFilter test case by 
inserting atleast another row. This works currently because we insert only one 
row ("row1"), perform export, perform import with prefix filter. The prefix 
filter filterRowKey is never called (before this fix) so all the rows are 
included in the import. But since we only have one row ("row1"), the test case 
doesn't really test the functionality of import with filter.

> Import.filterKv does not call Filter.filterRowKey
> -------------------------------------------------
>
>                 Key: HBASE-10505
>                 URL: https://issues.apache.org/jira/browse/HBASE-10505
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 0.96.2, 0.94.17
>
>         Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt
>
>
> The general contract of a Filter is that filterRowKey is called before 
> filterKeyValue.
> Import is using Filters for custom filtering but it does not called 
> filterRowKey at all. That throws off some Filters (such as RowFilter, and 
> more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and 
> HBASE-10485.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to