[ 
https://issues.apache.org/jira/browse/HBASE-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899892#comment-13899892
 ] 

Feng Honghua commented on HBASE-10497:
--------------------------------------

bq.(The helper method Threads.sleep is implemented as below:...) Wow. We should 
just remove Threads.sleep: it's a sure way to shoot ourselves in the foot... 
(it doesn't have to be done in this patch)
OK, the new jira HBASE-10516 is created for this purpose.

> Add standard handling for swallowed InterruptedException thrown by 
> Thread.sleep under HBase-Client/HBase-Server folders systematically
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10497
>                 URL: https://issues.apache.org/jira/browse/HBASE-10497
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>            Priority: Minor
>         Attachments: HBASE-10497-trunk_v1.patch, HBASE-10497-trunk_v2.patch
>
>
> There are many places where InterruptedException thrown by Thread.sleep are 
> swallowed silently (which are neither declared in the caller method's throws 
> clause nor rethrown immediately) under HBase-Client/HBase-Server folders.
> It'd be better to add standard 'log and call currentThread.interrupt' for 
> such cases.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to