[ 
https://issues.apache.org/jira/browse/HBASE-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Feng Honghua updated HBASE-10497:
---------------------------------

    Description: 
There are two kinds of handling problems for InterruptedException thrown by 
Thread.sleep in many places under HBase-Client/HBase-Server folders:
# Thread.currentThread.interrupt() is called within 'while' loops which can 
result in buggy behaviors such as expected sleep doesn't occur due to restored 
interrupt status by former loop, or even worse infinite loop
# InterruptedException thrown by Thread.sleep are swallowed silently (which are 
neither declared in the caller method's throws clause nor rethrown immediately)

  was:
There are many places where InterruptedException thrown by Thread.sleep are 
swallowed silently (which are neither declared in the caller method's throws 
clause nor rethrown immediately) under HBase-Client/HBase-Server folders.
It'd be better to add standard 'log and call currentThread.interrupt' for such 
cases.


> Correct wrong handling and add proper handling for swallowed 
> InterruptedException thrown by Thread.sleep under HBase-Client/HBase-Server 
> folders systematically
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10497
>                 URL: https://issues.apache.org/jira/browse/HBASE-10497
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>         Attachments: HBASE-10497-trunk_v1.patch, HBASE-10497-trunk_v2.patch
>
>
> There are two kinds of handling problems for InterruptedException thrown by 
> Thread.sleep in many places under HBase-Client/HBase-Server folders:
> # Thread.currentThread.interrupt() is called within 'while' loops which can 
> result in buggy behaviors such as expected sleep doesn't occur due to 
> restored interrupt status by former loop, or even worse infinite loop
> # InterruptedException thrown by Thread.sleep are swallowed silently (which 
> are neither declared in the caller method's throws clause nor rethrown 
> immediately)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to