[
https://issues.apache.org/jira/browse/HBASE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904431#comment-13904431
]
stack commented on HBASE-10539:
-------------------------------
I applied to 0.94 and 0.96
> HRegion.addAndGetGlobalMemstoreSize returns previous size
> ---------------------------------------------------------
>
> Key: HBASE-10539
> URL: https://issues.apache.org/jira/browse/HBASE-10539
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Feng Honghua
> Assignee: Feng Honghua
> Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.18
>
> Attachments: HBASE-10539-trunk_v1.patch
>
>
> HRegion.addAndGetGlobalMemstoreSize(addedSize) is called once some write
> succeeds and 'addedSize' is the size of the edits newly put to the memstore,
> the returned value of HRegion.addAndGetGlobalMemstoreSize(addedSize) is then
> checked against the flush threshold to determine if a flush for the region
> should be triggered.
> By design the returned value should be the updated memstore size after adding
> 'addedSize', but current implementation uses this.memstoreSize.getAndAdd
> which returns the previous size before adding, actually 'addAndGet' rather
> than 'getAndAdd' should be used here.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
