[ 
https://issues.apache.org/jira/browse/HBASE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068699#comment-13068699
 ] 

stack commented on HBASE-4094:
------------------------------

@Feng Thank you for digging in on this important issue.  As Jieshan asks, are 
you going to fix all the issues not already addressed by --fix listed above?  
If so, do you think it best to do it one per issue (if you'd rather piecemeal 
it) or do you want to make a monster patch to do them all in this issue?

I looked at your patch and it seems to comment out a line of code and add a 
comment.

Regards 18 above, when you say collect the regioninfo from regionserver and 
hdfs, what do you mean?  What if the region is not on a regionserver?  If its 
in the filesystem, how will you find it?  You only have the gap in the table 
and from here you need to get to the encoded name of the region in the 
filesystem.  Are you thinking of looking at all the regions in the filesystem 
and getting all of their .regioninfos and then checking for which has a start 
and stop key that matches the hole?

If this fails, yes, create a new region to bridge the hole.

Do you think this issue has overlap with HBASE-4058 Feng?

Thanks.


> improve hbck tool to fix more hbase problem
> -------------------------------------------
>
>                 Key: HBASE-4094
>                 URL: https://issues.apache.org/jira/browse/HBASE-4094
>             Project: HBase
>          Issue Type: New Feature
>          Components: master
>    Affects Versions: 0.90.3
>            Reporter: feng xu
>             Fix For: 0.90.5
>
>         Attachments: HbaseFsck_TableChain.patch
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to