[ 
https://issues.apache.org/jira/browse/HBASE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907577#comment-13907577
 ] 

Nicolas Liochon commented on HBASE-10525:
-----------------------------------------

bq. Is this sleep(1) intended, or left from debugging? 
Oops. left from debugging.

bq. minIdleTimeBeforeClose", 120000
Yes, I've changed it to see if it was the issue with TestHBaseFsck: if the 
connection becomes idle, the TestHBaseFsck fails. I will write a test on the 
RpcClient alone: there is no test for this feature. I can update it for the 
test itself, but I also need to check what it means for Fsck itself: may be it 
relies on having the same tcp connection. Lastly, the control of the idle 
connection is new (previously we were mixing bugs and client pings to keep the 
connection alive), I don't know what is the best value (but 2 minutes seems 
much better than 20 for sure)

> Allow the client to use a different thread for writing to ease interrupt
> ------------------------------------------------------------------------
>
>                 Key: HBASE-10525
>                 URL: https://issues.apache.org/jira/browse/HBASE-10525
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.99.0
>
>         Attachments: 10525.v1.patch, 10525.v2.patch, 10525.v3.patch, 
> 10525.v4.patch, 10525.v5.patch, HBaseclient-EventualConsistency.pdf
>
>
> This is an issue in the HBASE-10070 context, but as well more generally if 
> you want to interrupt an operation with a limited cost. 
> I will attach a doc with a more detailed explanation.
> This adds a thread per region server; so it's otional. The first patch 
> activates it by default to see how it behaves on a full hadoop-qa run. The 
> target is to be unset by default.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to